RussellSpitzer commented on code in PR #7153:
URL: https://github.com/apache/iceberg/pull/7153#discussion_r1143569581
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/TestSparkSessionCatalog.java:
##########
@@ -86,4 +87,26 @@ public void testValidateHmsUri() {
.defaultNamespace()[0]
.equals("default"));
}
+
+ @Test
+ public void testLoadFunction() {
+ String envHmsUriKey = "spark.hadoop." + METASTOREURIS.varname;
+ String catalogHmsUriKey = "spark.sql.catalog.spark_catalog.uri";
+ String hmsUri = hiveConf.get(METASTOREURIS.varname);
+
+ spark
Review Comment:
Now that this is in two places maybe it makes sense to put this in a
"beforeAll" method. Also when we do that we do that and extract this from the
above test as well, we can do
spark.conf().set("spark.sql.catalog.spark_catalog",
SparkSessionCatalog.class.getName)
If that fits on one line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
