amogh-jahagirdar commented on code in PR #6861:
URL: https://github.com/apache/iceberg/pull/6861#discussion_r1143967781
##########
api/src/main/java/org/apache/iceberg/view/ViewVersion.java:
##########
@@ -43,8 +47,7 @@ public interface ViewVersion {
long timestampMillis();
/**
- * Return the version summary such as the name of the operation that created
that version of the
- * view
+ * Return a string map of summary data for the operation that produced this
view version.
Review Comment:
Discussed offline with @jackye1995 we were talking on two different issues
here.
1.) The first is on strict validation of the `operation`, we concluded
that's probably not a desired behavior, and that's the behavior of `snapshot`
currently.
2.) The second is on the API and serialization of operation itself.
Operation will be serialized in the summary but when it's read we deserialize
it into a separate field in memory. This is the same as what happens with
`Snapshot` and I think it makes sense to have that same behavior and have a
separate API for operation. Updated the PR to reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
