jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1145050566
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -1061,18 +1103,30 @@ public Map<String, String> httpClientProperties() {
return httpClientProperties;
}
+ public String clientRegion() {
+ return clientRegion;
+ }
+
+ public void setClientRegion(String clientRegion) {
+ this.clientRegion = clientRegion;
+ }
+
/**
* Configure the credentials for an S3 client.
*
* <p>Sample usage:
*
* <pre>
- *
S3Client.builder().applyMutation(awsProperties::applyS3CredentialConfigurations)
+ *
S3Client.builder().applyMutation(awsProperties::applyCredentialConfigurations)
* </pre>
*/
- public <T extends S3ClientBuilder> void applyS3CredentialConfigurations(T
builder) {
- builder.credentialsProvider(
- credentialsProvider(s3AccessKeyId, s3SecretAccessKey, s3SessionToken));
+ public <T extends AwsClientBuilder> void applyCredentialConfigurations(T
builder) {
+ if (!Strings.isNullOrEmpty(this.clientCredentialsProvider)) {
+
builder.credentialsProvider(credentialsProvider(this.clientCredentialsProvider));
+ } else {
+ builder.credentialsProvider(
Review Comment:
also for `applyS3CredentialConfigurations`, I think if both
`clientCredentialsProvider ` and `s3AccessKeyId, s3SecretAccessKey,
s3SessionToken` configurations are set, we probably prefers to take the S3 one
because it is an S3 level override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
