aokolnychyi commented on code in PR #6919:
URL: https://github.com/apache/iceberg/pull/6919#discussion_r1145486114


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -420,12 +421,14 @@ private Scan buildBatchScan() {
   private Scan buildBatchScan(Long snapshotId, Long asOfTimestamp, String 
branch, String tag) {
     Schema expectedSchema = schemaWithMetadataColumns();
 
+    SparkMetricsReporter reporter = new SparkMetricsReporter();

Review Comment:
   I don't think there is any value in this class at this point. Let's remove 
Spark classes from this PR and add them when we know how the reporting logic 
will look like.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to