JonasJ-ap commented on code in PR #7148: URL: https://github.com/apache/iceberg/pull/7148#discussion_r1145513360
########## python/pyproject.toml: ########## @@ -100,6 +102,7 @@ build-backend = "poetry.core.masonry.api" pyarrow = ["pyarrow"] pandas = ["pandas", "pyarrow"] duckdb = ["duckdb", "pyarrow"] +ray = ["ray", "pyarrow", "pandas"] Review Comment: @Fokko Yes. The `pandas` seems to be a required dependency when converting from `pa.Table` to ray dataset. Here is the trace when running `table.scan().to_ray()` without `pandas`: ```bash 2023-03-22 19:22:32,946 INFO worker.py:772 -- Task failed with retryable exception: TaskID(c8ef45ccd0112571ffffffffffffffffffffffff01000000). (_get_metadata pid=77891) Traceback (most recent call last): (_get_metadata pid=77891) File "python/ray/_raylet.pyx", line 857, in ray._raylet.execute_task (_get_metadata pid=77891) File "python/ray/_raylet.pyx", line 861, in ray._raylet.execute_task (_get_metadata pid=77891) File "/Users/jonasjiang/Library/Caches/pypoetry/virtualenvs/pyiceberg-oQQETec1-py3.9/lib/python3.9/site-packages/ray/data/read_api.py", line 1565, in _get_metadata (_get_metadata pid=77891) return BlockAccessor.for_block(table).get_metadata( (_get_metadata pid=77891) File "/Users/jonasjiang/Library/Caches/pypoetry/virtualenvs/pyiceberg-oQQETec1-py3.9/lib/python3.9/site-packages/ray/data/block.py", line 379, in for_block (_get_metadata pid=77891) import pandas (_get_metadata pid=77891) ModuleNotFoundError: No module named 'pandas' ``` Here is the reference for `for_block` method in ray: https://github.com/ray-project/ray/blob/2e6de87ada84609fcd4f85bd16b9c2e090e921ae/python/ray/data/block.py#L379-L394 The `import pandas` cause this requirement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
