singhpk234 commented on code in PR #7011:
URL: https://github.com/apache/iceberg/pull/7011#discussion_r1146923339
##########
core/src/test/java/org/apache/iceberg/TestSplitPlanning.java:
##########
@@ -249,6 +249,23 @@ public void testBasicSplitPlanningDeleteFiles() {
Assert.assertEquals(8,
Iterables.size(posDeletesTable.newBatchScan().planTasks()));
}
+ @Test
+ public void testBasicSplitPlanningDeleteFilesWithSplitOffsets() {
+ table.updateProperties().set(TableProperties.FORMAT_VERSION, "2").commit();
+ List<DeleteFile> files128Mb = newDeleteFiles(4, 128 * 1024 * 1024, 8);
+ appendDeleteFiles(files128Mb);
+
+ PositionDeletesTable posDeletesTable = new PositionDeletesTable(table);
+ // we expect 8 bins since split size is 64MB
+ Assert.assertEquals(
Review Comment:
@szehon-ho can you please take another pass. Apologies it took me so long to
get back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
