nastra commented on code in PR #7194:
URL: https://github.com/apache/iceberg/pull/7194#discussion_r1147500900
##########
core/src/main/java/org/apache/iceberg/metrics/CommitReport.java:
##########
@@ -19,12 +19,15 @@
package org.apache.iceberg.metrics;
import java.util.Map;
+import org.apache.iceberg.TableOperations;
import org.immutables.value.Value;
/** A commit report that contains all relevant information from a Snapshot. */
@Value.Immutable
public interface CommitReport extends MetricsReport {
+ TableOperations tableOperations();
Review Comment:
I don't think there should be any coupling between `TableOperations` and any
subtype of `MetricsReport`. The purpose of a `MetricsReport` is to only carry
final results from a scan/commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
