ChristinaTech commented on issue #7151: URL: https://github.com/apache/iceberg/issues/7151#issuecomment-1483484397
So on fleshing out to the prototype I realized it has a number of flaws: * Ends up requiring us to recreate and control all of AWS's built in retry logic to avoid introducing any unexpected side effects. * Effectively overrides any retry policy changes provided by a customer if they provide a custom AWS client factory. * Requires us to merge ClientOverrideConfiguration from multiple Iceberg AWS client mutators. Also requires the same thing on the RetryPolicy object inside it. * Doesn't end up integrating as well with the Iceberg `Tasks` lifecycle as originally intended. I will put out a PR later today with an alternative solution that should have fewer potential side effects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
