ConeyLiu commented on code in PR #3249:
URL: https://github.com/apache/iceberg/pull/3249#discussion_r1148891098
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java:
##########
@@ -166,12 +169,20 @@ public ArrowVectorAccessor<DecimalT, Utf8StringT, ArrayT,
ChildVectorT> getVecto
@SuppressWarnings("checkstyle:CyclomaticComplexity")
private ArrowVectorAccessor<DecimalT, Utf8StringT, ArrayT, ChildVectorT>
getPlainVectorAccessor(
- FieldVector vector) {
+ FieldVector vector, PrimitiveType primitive) {
+ boolean isDecimal =
+ primitive != null &&
OriginalType.DECIMAL.equals(primitive.getOriginalType());
if (vector instanceof BitVector) {
return new BooleanAccessor<>((BitVector) vector);
} else if (vector instanceof IntVector) {
+ if (isDecimal) {
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
