ConeyLiu commented on PR #3249: URL: https://github.com/apache/iceberg/pull/3249#issuecomment-1488001749
@nastra benchmark results at [here](https://github.com/ConeyLiu/iceberg/actions/runs/4549932541) ``` Benchmark Mode Cnt Score Error Units VectorizedReadFlatParquetDataBenchmark.readBigDecimalsIcebergVectorized5k ss 5 9.512 ± 0.092 s/op VectorizedReadFlatParquetDataBenchmark.readBigDecimalsSparkVectorized5k ss 5 9.206 ± 0.145 s/op VectorizedReadFlatParquetDataBenchmark.readDatesIcebergVectorized5k ss 5 2.482 ± 0.187 s/op VectorizedReadFlatParquetDataBenchmark.readDatesSparkVectorized5k ss 5 2.492 ± 0.139 s/op VectorizedReadFlatParquetDataBenchmark.readDecimalsIcebergVectorized5k ss 5 5.154 ± 0.169 s/op VectorizedReadFlatParquetDataBenchmark.readDecimalsSparkVectorized5k ss 5 4.057 ± 0.079 s/op VectorizedReadFlatParquetDataBenchmark.readDoublesIcebergVectorized5k ss 5 4.546 ± 0.342 s/op VectorizedReadFlatParquetDataBenchmark.readDoublesSparkVectorized5k ss 5 3.897 ± 0.113 s/op VectorizedReadFlatParquetDataBenchmark.readFloatsIcebergVectorized5k ss 5 3.803 ± 0.096 s/op VectorizedReadFlatParquetDataBenchmark.readFloatsSparkVectorized5k ss 5 3.735 ± 0.185 s/op VectorizedReadFlatParquetDataBenchmark.readIntegersIcebergVectorized5k ss 5 4.021 ± 0.144 s/op VectorizedReadFlatParquetDataBenchmark.readIntegersSparkVectorized5k ss 5 3.493 ± 0.095 s/op VectorizedReadFlatParquetDataBenchmark.readLongsIcebergVectorized5k ss 5 4.056 ± 0.321 s/op VectorizedReadFlatParquetDataBenchmark.readLongsSparkVectorized5k ss 5 3.177 ± 0.214 s/op VectorizedReadFlatParquetDataBenchmark.readStringsIcebergVectorized5k ss 5 5.387 ± 0.089 s/op VectorizedReadFlatParquetDataBenchmark.readStringsSparkVectorized5k ss 5 6.683 ± 0.130 s/op VectorizedReadFlatParquetDataBenchmark.readTimestampsIcebergVectorized5k ss 5 2.283 ± 0.136 s/op VectorizedReadFlatParquetDataBenchmark.readTimestampsSparkVectorized5k ss 5 2.208 ± 0.091 s/op ``` ``` Benchmark Mode Cnt Score Error Units VectorizedReadParquetDecimalBenchmark.readDecimalsIcebergVectorized5k ss 5 12.878 ± 0.512 s/op VectorizedReadParquetDecimalBenchmark.readDecimalsSparkVectorized5k ss 5 11.764 ± 0.654 s/op VectorizedReadParquetDecimalBenchmark.readIntBackedDecimalsIcebergVectorized5k ss 5 2.711 ± 0.214 s/op VectorizedReadParquetDecimalBenchmark.readIntBackedDecimalsSparkVectorized5k ss 5 2.698 ± 0.165 s/op VectorizedReadParquetDecimalBenchmark.readLongBackedDecimalsIcebergVectorized5k ss 5 4.728 ± 0.310 s/op VectorizedReadParquetDecimalBenchmark.readLongBackedDecimalsSparkVectorized5k ss 5 5.356 ± 0.320 s/op ``` > can we remove IntBackedDecimalBatchReader / LongBackedDecimalBatchReader / FixedLengthDecimalBatchReader / IntBackedDecimalPageReader / LongBackedDecimalPageReader? Those methods/classes are public, is it safe to delete them? Or mark them as deprecated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
