hililiwei commented on code in PR #7236:
URL: https://github.com/apache/iceberg/pull/7236#discussion_r1152963983
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -613,8 +617,9 @@ static CatalogTable toCatalogTable(Table table) {
// may use
// CatalogTableImpl to copy a new catalog table.
// Let's re-loading table from Iceberg catalog when creating source/sink
operators.
- // Iceberg does not have Table comment, so pass a null (Default comment
value in Flink).
- return new CatalogTableImpl(schema, partitionKeys, table.properties(),
null);
+ Map<String, String> prop = Maps.newHashMap(table.properties());
+ String comment = prop.remove(COMMENT);
Review Comment:
Iceberg does not have Table comment, and we never seem to get a value here.
We don't seem to need to change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
