nastra commented on code in PR #7251:
URL: https://github.com/apache/iceberg/pull/7251#discussion_r1154177709
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -76,30 +79,38 @@ public class TestS3RestSigner {
public MinioContainer minioContainer =
new MinioContainer(CREDENTIALS_PROVIDER.resolveCredentials());
- @AfterClass
- public static void afterClass() throws Exception {
- if (null != httpServer) {
- httpServer.stop();
- }
- }
-
- @Before
- public void before() throws Exception {
+ @BeforeClass
Review Comment:
I have restructured the test slightly so that the same Signer instance is
used for all tests. When the scheduler existed in the code, it clearly showed
the resource leak that was happening when tokens were being scheduled for
refresh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
