gong commented on PR #7217:
URL: https://github.com/apache/iceberg/pull/7217#issuecomment-1492881770
> > > partition is too much. Snapshot data is partitioned by yyyy-mm-dd
format of create_time field. I set 5 parallelisms and checkpoint interval is 1
min.
> >
> >
> > Sounds like it's a streaming job? Do you receive very many different
partitions (days) in one checkpoint cycle (1 min)? In my experience, it's
usually in single digits. I'm a little confused about that.
> > Of course, I'm not against using LRU, just curious about your case.
>
> @hililiwei Partition field data is discrete when read snapshot phase. I
write a defective code when use LRU map. Beacause I don't close writer. Thanks
for your suggestion. I increase memory to avoid oom but checkpoint time is too
long. I think cost many time to close writer. I increase checkpoint interval to
avoid frequently close writer. Do you have any suggestion?
@hililiwei I modify PartitionedDeltaWriter#close method to paralle close. It
can reduce checkpoint time.
```java
Tasks.foreach(writers.values())
.throwFailureWhenFinished()
.noRetry()
.executeWith(EXECUTOR_SERVICE) // set a ExecutorService
object
.run(RowDataDeltaWriter::close, IOException.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
