zhongyujiang commented on code in PR #7249:
URL: https://github.com/apache/iceberg/pull/7249#discussion_r1155847420
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -444,6 +444,12 @@ private void validateNoNewDeletesForDataFiles(
if (parent == null || base.formatVersion() < 2) {
return;
}
+ List<Snapshot> snapshots =
+ Lists.newArrayList(
+ SnapshotUtil.ancestorsBetween(
+ base.currentSnapshot().snapshotId(), startingSnapshotId,
base::snapshot));
+ boolean ignorePositionDeletes =
+
snapshots.stream().allMatch(this::cannotContainPosDeletesForPreviousSnapshots);
Review Comment:
Another issue came to my mind is that when there are overwrite operation
snapshots committed by other engines, this will return `false` and the next
verification step will still validate the pos deletes committed by Flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
