jackye1995 commented on code in PR #7262:
URL: https://github.com/apache/iceberg/pull/7262#discussion_r1156360544
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -194,9 +195,29 @@ private void openStream() throws IOException {
}
}
- private void closeStream() throws IOException {
+ private void closeStream() {
if (stream != null) {
- stream.close();
+ // if we aren't at the end of the stream, and the stream is abortable,
then
+ // call abort() so we don't read the remaining data with the Apache HTTP
client
+ abortStream();
+ try {
+ stream.close();
+ } catch (Exception e) {
+ // log at trace level as closing an aborted stream will throw a
content length
+ // check exception with the Apache HTTP client
+ LOG.trace("Error closing stream", e);
Review Comment:
That means we will see exceptions for every stream close if trace is
enabled. If it is expected to fail with the content length check, can we at
least skip that? Then we don't need to log in trace, but we can log in maybe a
warning level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
