hililiwei commented on code in PR #7171:
URL: https://github.com/apache/iceberg/pull/7171#discussion_r1156945498
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -390,4 +393,40 @@ public void testOverrideWriteConfigWithUnknownFileFormat()
{
return null;
});
}
+
+ @Test
+ public void testPartitionEvolution() throws Exception {
Review Comment:
On second thought, I don't think this UT is stable enough. My test also
confirmed my point, I ran the UT many times, sometimes it passed, sometimes it
didn't.
I think we should use `TestIcebergFilesCommitter` to test it. Specifically,
we can change the table's spec between commits to validate your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
