abmo-x commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1157909282
##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##########
@@ -284,6 +284,15 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
}
}
+ @Override
+ public boolean dropNamespace(Namespace namespace, boolean cascade)
+ throws NamespaceNotEmptyException {
+ if (cascade) {
+ listTables(namespace).forEach(this::dropTable);
Review Comment:
dropTable is overloaded and has two methods, 1 with just single arg
TableIdentifier and another which takes the `boolean purge` arg, we are using
the former one here where purge is false.
addressed the purge comment here (TBD)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
