dpaani commented on code in PR #7188:
URL: https://github.com/apache/iceberg/pull/7188#discussion_r1159996108
##########
api/src/main/java/org/apache/iceberg/io/LocationProvider.java:
##########
@@ -28,6 +28,19 @@
* <p>Implementations must be {@link Serializable} because instances will be
serialized to tasks.
*/
public interface LocationProvider extends Serializable {
+
+ /**
+ * Returns the fully-qualified data location for a table, where data files
such as Parquet, ORC,
+ * or Avro are stored. The table data location can be retrieved from the
table properties input,
+ * such as 'write.data.path', or from 'write.object-storage.path'
(deprecated), or from
+ * 'write.folder-storage.path' (deprecated). Refer to the implementation
class of {@link
+ * LocationProvider} for more details.
+ */
+ default String dataLocation() {
+ throw new UnsupportedOperationException(
+ String.format("%s does not expose dataLocation",
this.getClass().getCanonicalName()));
Review Comment:
hi @RussellSpitzer As discussed, I removed dataLocation() new API from this
PR and will add it as separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
