szehon-ho commented on code in PR #7190:
URL: https://github.com/apache/iceberg/pull/7190#discussion_r1160314442
##########
core/src/test/java/org/apache/iceberg/MetadataTableScanTestBase.java:
##########
@@ -79,24 +80,25 @@ protected void validateTaskScanResiduals(TableScan scan,
boolean ignoreResiduals
}
}
- protected void validateIncludesPartitionScan(
- CloseableIterable<FileScanTask> tasks, int partValue) {
- validateIncludesPartitionScan(tasks, 0, partValue);
+ /** Used for asserting on data files where partition size = 1 */
Review Comment:
Thanks !
I think name /comment is a bit misleading. The partition size = 1 seems
misleading (to me, it means how many partitions..), I think we want to mean
that partition fields size is 1. If we change the name, how about
validateSingleFieldPartition(), and then maybe fix/remove the comment (remove
if its a redundant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
