ggershinsky commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r1161548526


##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/data/parquet/vectorized/TestParquetVectorizedReads.java:
##########
@@ -139,6 +164,19 @@ FileAppender<GenericData.Record> getParquetWriter(Schema 
schema, File testFile)
     return 
Parquet.write(Files.localOutput(testFile)).schema(schema).named("test").build();
   }
 
+  FileAppender<GenericData.Record> getEncryptedParquetWriter(Schema schema, 
File testFile)

Review Comment:
   this is named after the existing `getParquetWriter` and `getParquetV2Writer` 
methods. Will change all in this class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to