frankliee commented on code in PR #7310:
URL: https://github.com/apache/iceberg/pull/7310#discussion_r1162234862
##########
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##########
@@ -147,4 +147,8 @@ private void release(C client) {
public int poolSize() {
return poolSize;
}
+
+ public boolean isClosed() {
Review Comment:
@VisibleForTesting + public cannot pass Iceberg's style check, so I use
public.
Since `boolean isClosed()` is read-only function, public will not introduce
risks.
Besides, `int poolSize()` is this class is also public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
