szehon-ho commented on code in PR #7324:
URL: https://github.com/apache/iceberg/pull/7324#discussion_r1163398305
##########
core/src/test/java/org/apache/iceberg/TestSortOrder.java:
##########
@@ -365,4 +367,26 @@ public void testPreservingOrderSortedColumnNames() {
Set<String> sortedCols = SortOrderUtil.orderPreservingSortedColumns(order);
Assert.assertEquals(ImmutableSet.of("data"), sortedCols);
}
+
+ @Test
+ public void testCaseSensitiveSortedColumnNames() {
Review Comment:
Is this test is testing any new code (looks like SortOrderBuilder
caseSensitive was already implemented before)? If we want an API level test,
shouldnt it be for testing BaseReplaceSortOrder (which is the new code)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
