szehon-ho commented on code in PR #7120:
URL: https://github.com/apache/iceberg/pull/7120#discussion_r1165819216
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -115,6 +121,20 @@ public String wapId() {
return sessionConf.get("spark.wap.id", null);
}
+ public int outputSpecId() {
+ final int outputSpecId =
Review Comment:
Nit: Would you mind remove 'final' here? I know from @aokolnychyi (when he
reviewed me change), he prefers not to have extra finals except in class
fields, as modern compiler usually adds it anyway. ex:
https://github.com/apache/iceberg/pull/4293#discussion_r823011381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
