aokolnychyi commented on code in PR #7324:
URL: https://github.com/apache/iceberg/pull/7324#discussion_r1165968120
##########
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/SetWriteDistributionAndOrderingExec.scala:
##########
@@ -47,6 +48,7 @@ case class SetWriteDistributionAndOrderingExec(
val txn = iceberg.table.newTransaction()
val orderBuilder = txn.replaceSortOrder()
+ orderBuilder.caseSensitive(session.conf.get(SQLConf.CASE_SENSITIVE,
SQLConf.CASE_SENSITIVE.defaultValue.get))
Review Comment:
We do expose `findField` and `caseInsensitiveFindField` in `Schema` but we
need to somehow indicate which version to use. Given that this PR just exposes
what's already implemented, I feel it should be OK. It is similar to what we do
in other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
