aokolnychyi commented on code in PR #7326:
URL: https://github.com/apache/iceberg/pull/7326#discussion_r1165978188


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##########
@@ -101,6 +103,7 @@ public class CreateChangelogViewProcedure extends 
BaseProcedure {
         COMPUTE_UPDATES_PARAM,
         REMOVE_CARRYOVERS_PARAM,
         IDENTIFIER_COLUMNS_PARAM,
+        NET_CHANGES,

Review Comment:
   Option 1 can be served as a temp workaround as there is no way to pass 
options in SQL, so we can't configure snapshot ranges when using `changes` 
directly.
   
   Russell does bring a valid point that we can't set `compute_updates` or 
`remove_carryovers` to false if the new flag is true. Let me think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to