nastra commented on code in PR #7144:
URL: https://github.com/apache/iceberg/pull/7144#discussion_r1147666190
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -247,6 +252,18 @@ public Map<String, SnapshotRef> refs() {
return refs;
}
+ @Override
+ public MetricsReporter metricsReporter() {
+ if (lazyMetricsReporter == null) {
+ synchronized (this) {
+ if (lazyMetricsReporter == null) {
+ lazyMetricsReporter =
CatalogUtil.loadMetricsReporter(this.metricsReporterProperties);
Review Comment:
this is actually wrong and this should pass `properties` so that we have
`CatalogUtil.loadMetricsReporter(this.properties)`
To finish the initialization of the metrics reporter after it was loaded,
you'd have to do
`lazyMetricsReporter.initialize(this.metricsReporterProperties)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
