gustavoatt commented on code in PR #7352:
URL: https://github.com/apache/iceberg/pull/7352#discussion_r1167314470
##########
core/src/main/java/org/apache/iceberg/StaticDataTask.java:
##########
@@ -71,8 +71,10 @@ public List<DeleteFile> deletes() {
@Override
public CloseableIterable<StructLike> rows() {
- StructProjection projection = StructProjection.create(tableSchema,
projectedSchema);
- Iterable<StructLike> projectedRows =
Iterables.transform(Arrays.asList(rows), projection::wrap);
+ Iterable<StructLike> projectedRows =
Review Comment:
Note that I changed this to always create a new `StructProjection`. Without
this all the rows when reading metadata tables were identical since they kept
using the same projection.
I don't believe this should be problematic since `StaticDataTask` is only
used for metadata tables, but happy to hear any alternatives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
