singhpk234 commented on code in PR #7353:
URL: https://github.com/apache/iceberg/pull/7353#discussion_r1167994007
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/TestTableSerialization.java:
##########
@@ -33,11 +33,25 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+@RunWith(Parameterized.class)
public class TestTableSerialization {
+ public TestTableSerialization(String isObjectStoreEnabled) {
+ this.isObjectStoreEnabled = isObjectStoreEnabled;
+ }
+
+ @Parameterized.Parameters(name = "isObjectStoreEnabled = {0}")
+ public static Object[] parameters() {
+ return new Object[] {"true", "false"};
Review Comment:
Side note : presently it's just testing serialization with kryo serializer,
imho we should have tests for java serializer as well, happy to add these as
well, if we all agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
