rdblue commented on code in PR #6997: URL: https://github.com/apache/iceberg/pull/6997#discussion_r1168049246
########## python/pyiceberg/io/pyarrow.py: ########## @@ -122,6 +126,12 @@ ONE_MEGABYTE = 1024 * 1024 BUFFER_SIZE = "buffer-size" ICEBERG_SCHEMA = b"iceberg.schema" +FIELD_ID = "field_id" +FIELD_DOC = "doc" Review Comment: Should this constant name match its contents? That's what we would normally do so that code is readable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
