nastra commented on code in PR #7361:
URL: https://github.com/apache/iceberg/pull/7361#discussion_r1169694391
##########
.palantir/revapi.yml:
##########
@@ -426,6 +426,12 @@ acceptedBreaks:
- code: "java.field.removedWithConstant"
old: "field org.apache.iceberg.TableProperties.HMS_TABLE_OWNER"
justification: "Removing deprecations for 1.3.0"
+ - code: "java.method.numberOfParametersChanged"
Review Comment:
we typically don't want to introduce breaking API changes that haven't gone
through a deprecation cycle first. See
https://iceberg.apache.org/contribute/#minor-version-deprecations-required for
some details.
##########
core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java:
##########
@@ -35,26 +35,32 @@
public class RewriteFileGroup {
private final FileGroupInfo info;
private final List<FileScanTask> fileScanTasks;
+ private boolean isFailed;
private Set<DataFile> addedFiles = Collections.emptySet();
- public RewriteFileGroup(FileGroupInfo info, List<FileScanTask>
fileScanTasks) {
+ public RewriteFileGroup(FileGroupInfo info, List<FileScanTask>
fileScanTasks, boolean isFailed) {
Review Comment:
do we really need to pass a boolean here or could we derive that info maybe
in a different way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
