nastra commented on code in PR #7387:
URL: https://github.com/apache/iceberg/pull/7387#discussion_r1172852118
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -108,6 +110,9 @@ public void initialize(String inputName, Map<String,
String> properties) {
: CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
this.clients = new CachedClientPool(conf, properties);
+
+ EnvironmentContext.put(EnvironmentContext.ENGINE_NAME, "hive");
+ EnvironmentContext.put(EnvironmentContext.ENGINE_VERSION,
HiveVersionInfo.getVersion());
Review Comment:
in that case Spark would overwrite whatever was set by Hive in
https://github.com/apache/iceberg/blob/master/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java#L555-L558
with its own engine name/version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
