nastra commented on code in PR #7339:
URL: https://github.com/apache/iceberg/pull/7339#discussion_r1174924440
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -127,7 +127,7 @@ public <T extends RESTResponse> T execute(
// this doesn't use a Mockito spy because this is used for catalog
tests, which have
// different method calls
if (!"v1/oauth/tokens".equals(path)) {
- if ("v1/config".equals(path)) {
+ if ("v1/config".equals(path) || path.endsWith("/metrics")) {
Review Comment:
this is because now we only instantiate a single metrics reporter and use
the headers from the catalog's `AuthSession`.
In case that is a concern, we could instantiate a new reporter wherever we
currently pass in the `reporter` and then use the headers from
`session::headers`.
In fact that approach might be better as we wouldn't need to derive the
`TableIdentifier` from the metrics report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
