singhpk234 commented on code in PR #7422:
URL: https://github.com/apache/iceberg/pull/7422#discussion_r1175903900
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -255,6 +255,22 @@ public Long endTimestamp() {
return
confParser.longConf().option(SparkReadOptions.END_TIMESTAMP).parseOptional();
}
+ public Integer maxFilesPerMicroBatch() {
Review Comment:
Agree with you, ideally it's not required, I think might have just picked up
from previous conf's like below :
https://github.com/apache/iceberg/blob/e2c7e77310329b2113d4122eda4bd0d46e1d252d/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java#L242-L248
Let me create a pr to clean up the conf's introduced above as well as
existing conf's to just return primitive types, if it's not optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
