nastra commented on code in PR #7399:
URL: https://github.com/apache/iceberg/pull/7399#discussion_r1177406276
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ArrowVectorAccessorFactory.java:
##########
@@ -74,6 +76,11 @@ public UTF8String ofRow(VarCharVector vector, int rowId) {
null, vector.getDataBuffer().memoryAddress() + start, end - start);
}
+ @Override
+ public UTF8String ofRow(FixedSizeBinaryVector vector, int rowId) {
+ return
UTF8String.fromString(UUIDUtil.convert(vector.get(rowId)).toString());
Review Comment:
`vector.get(rowId)` will return the byte[] with a length of 16 for the given
`rowId`. I think we could get underlying array and offset from the underlying
`ArrowBuf`, but we would need to read it into a new byte[], which is what
`vector.get(rowId)` is doing underneath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
