hililiwei commented on code in PR #5984:
URL: https://github.com/apache/iceberg/pull/5984#discussion_r1179333851
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -96,6 +96,9 @@ public MetricsReporter metricsReporter() {
return LoggingMetricsReporter.instance();
}
+ @Nullable
+ public abstract String branch();
Review Comment:
oh, I know what you mean now, but I have a question. Even though
TableScanContext is an internal class, I think it encapsulates the scanning
semantics, such as having methods like `useSnapshotId`,
`fromSnapshotIdExclusive`, etc. So let’s imagine, if there is a `Tag` here,
what would be its use case and how would it relate to Branch. Assuming there is
a `fromTagExclusive`, then it would require a Tag, but at the same time, it
might also be able to use a Branch. From this perspective, we might need both
`tag` and `branch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
