jackye1995 commented on code in PR #7450:
URL: https://github.com/apache/iceberg/pull/7450#discussion_r1179550048
##########
delta-lake/src/main/java/org/apache/iceberg/delta/BaseSnapshotDeltaLakeTableAction.java:
##########
@@ -412,6 +426,25 @@ private Map<String, String> destTableProperties(
return additionalPropertiesBuilder.build();
}
+ private void tagCurrentSnapshot(long deltaVersion, Transaction transaction) {
+ long currentSnapshotId =
transaction.table().currentSnapshot().snapshotId();
+
+ ManageSnapshots manageSnapshots = transaction.manageSnapshots();
+ manageSnapshots.createTag(DELTA_VERSION_TAG_PREFIX + deltaVersion,
currentSnapshotId);
+
+ Timestamp deltaVersionTimestamp =
deltaLog.getCommitInfoAt(deltaVersion).getTimestamp();
+ if (deltaVersionTimestamp != null) {
+ String formattedDeltaTimestamp =
+ deltaVersionTimestamp
+ .toInstant()
+ .atZone(ZoneId.of(DELTA_TIME_STAMP_ZONE))
+ .format(DateTimeFormatter.ofPattern(DELTA_TIME_STAMP_FORMAT));
Review Comment:
I am wondering how much it is worth doing this conversion, instead of just
using the millisecond timestamp value. Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
