aokolnychyi commented on code in PR #7443: URL: https://github.com/apache/iceberg/pull/7443#discussion_r1179587617
########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkFunctionCatalog.java: ########## @@ -16,23 +16,30 @@ * specific language governing permissions and limitations * under the License. */ +package org.apache.iceberg.spark; Review Comment: I also thought a bit about it but then looked at all our other classes like `SparkCatalog`, `SparkWrite`, etc. I guess it makes sense to follow this pattern because catalogs are referred using the qualified name that includes the package too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
