aokolnychyi commented on code in PR #7389: URL: https://github.com/apache/iceberg/pull/7389#discussion_r1179656720
########## core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java: ########## @@ -101,6 +101,8 @@ public static final long MAX_FILE_GROUP_SIZE_BYTES_DEFAULT = 100L * 1024 * 1024 * 1024; // 100 GB + protected static final long SPLIT_OVERHEAD = 5 * 1024; Review Comment: Shall we also drop this constant from `SparkBinPackDataRewriter`? It is no longer used there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
