DarthData410 commented on issue #7458: URL: https://github.com/apache/iceberg/issues/7458#issuecomment-1527958755
Hey @Fokko I do have a specific question for one of the warnings showing up for mkdocs serve --strict mode. Specifically for iceberg/python/pyiceberg/table/sorting.py. Within the class def for class SortOrder, the comments reference truly a parameter that is not contained within the def __init__(...). The comments suggest it should be, and it is not inherited from the IcebergBaseModel or BaseModel (imported from pydantic). The code has a self.property of order_id, with a default value being initialized, yet the ability to set this value for a class instance on creating a new instance of it, does not exists as the comments hint towards. Hence why the warning for this specific instance if being generated by mkdocs. Have a look at the code here: https://github.com/apache/iceberg/blob/78aafdb55e65463fb518714b4c1d164ce890cc2b/python/pyiceberg/table/sorting.py#L110 Either the comments need to remove the order_id: as a valid Arg, or the Python logic for the init needs to be updated to include the order_id as a valid arg. Args: order_id (int): An unique id of the sort-order of a table. fields (List[SortField]): The fields how the table is sorted Thoughts? New Issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
