youngxinler commented on code in PR #6886:
URL: https://github.com/apache/iceberg/pull/6886#discussion_r1180954866
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -132,6 +132,9 @@ protected Catalog buildIcebergCatalog(String name,
CaseInsensitiveStringMap opti
optionsMap.putAll(options.asCaseSensitiveMap());
optionsMap.put(CatalogProperties.APP_ID,
SparkSession.active().sparkContext().applicationId());
optionsMap.put(CatalogProperties.USER,
SparkSession.active().sparkContext().sparkUser());
+ optionsMap.putIfAbsent(
Review Comment:
If it is HadoopCatalog, warehouse must be set; if it is HiveCatalog, the
default value is HiveConf.ConfVars.METASTOREWAREHOUSE.varname; if it is
SparkCatalog, the default value is spark.sql.warehouse.dir. Now if
spark.sql.catalog is not set. $catalogName.warehouse, then
spark.sql.warehouse.dir will be used. For HiveCatalog, if a namespace has been
created, then warehouse will be a certain value.
So I think this will have no impact on previous performance .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
