Fokko commented on PR #7301:
URL: https://github.com/apache/iceberg/pull/7301#issuecomment-1528874719

   Looks like this commit made the bloom tests on the Iceberg side fail:
   ```
   ➜  parquet-mr git:(4e9e79c89) ✗  git bisect bad
   4e9e79c895e61775066e11240729b574e2264b8b is the first bad commit
   commit 4e9e79c895e61775066e11240729b574e2264b8b
   Author: ChenLiang.Lu <[email protected]>
   Date:   Mon Feb 27 15:45:46 2023 +0800
   
       PARQUET-2251 Avoid generating Bloomfilter when all pages of a column are 
encoded by dictionary in parquet v1 (#1033)
   
    .../apache/parquet/hadoop/ParquetFileWriter.java   |   3 +-
    .../apache/parquet/hadoop/TestBloomFiltering.java  |  18 ++-
    .../parquet/hadoop/TestStoreBloomFilter.java       | 132 
+++++++++++++++++++++
    3 files changed, 151 insertions(+), 2 deletions(-)
    create mode 100644 
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestStoreBloomFilter.java
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to