nastra commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1183615627
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -874,4 +874,17 @@ private static Cache<String, AuthSession>
newSessionCache(Map<String, String> pr
(RemovalListener<String, AuthSession>) (id, auth, cause) ->
auth.stopRefreshing())
.build();
}
+
+ private Cache<TableIdentifier, FileIO> newFileIOCache() {
+ return Caffeine.newBuilder()
Review Comment:
The cache itself doesn't have a close but it provides methods to perform
clean up and invalidation. I've added calls to that when `close()` on the
catalog is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
