nastra commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1183973873


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -873,4 +904,20 @@ private static Cache<String, AuthSession> 
newSessionCache(Map<String, String> pr
             (RemovalListener<String, AuthSession>) (id, auth, cause) -> 
auth.stopRefreshing())
         .build();
   }
+
+  private Cache<TableOperations, FileIO> newFileIOCloser() {
+    return Caffeine.newBuilder()
+        .scheduler(

Review Comment:
   I would probably go without a scheduler (I left this here from some previous 
experimentation). See my other comment in 
https://github.com/apache/iceberg/pull/7487#discussion_r1183971466 on that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to