rdblue commented on code in PR #7504: URL: https://github.com/apache/iceberg/pull/7504#discussion_r1184070596
########## format/view-spec.md: ########## @@ -111,12 +111,13 @@ The SQL representation stores the view definition as a SQL SELECT, with metadata |-------------|---------------------|----------------|-------------| | _required_ | `type` | `string` | Must be `sql` | | _required_ | `sql` | `string` | A SQL SELECT statement | -| _required_ | `dialect` | `string` | The dialect of the `sql` SELECT statement (e.g., "trino" or "spark") | +| _required_ | `dialect` | `string` | The dialect of the `sql` SELECT statement (e.g., "trino" or "spark"). Unless a version is provided only one view definition for each `type` and `dialect` should be present in a view definition. | Review Comment: I don't think we want to include version information here. Isn't SQL generally compatible across versions? While you could add to the dialect, we expect SQL to be backward-compatible. If additions are not supported, then the SQL will fail to be parsed or analyzed. We would not want to reject a dialect if it is a newer version because that would prevent using many SQL queries that are compatible with older versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
