ConeyLiu commented on code in PR #5659: URL: https://github.com/apache/iceberg/pull/5659#discussion_r1185990876
########## core/src/main/java/org/apache/iceberg/SystemConfigs.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.function.Function; + +/** + * Configuration properties that are controlled by Java system properties or environmental variable. + */ +public class SystemConfigs { + + private SystemConfigs() {} + + /** + * Sets the size of the worker pool. The worker pool limits the number of tasks concurrently + * processing manifests in the base table implementation across all concurrent planning or commit + * operations. + */ + public static final ConfigEntry<Integer> WORKER_THREAD_POOL_SIZE = + new ConfigEntry<>( + "iceberg.worker.num-threads", + "ICEBERG_WORKER_NUM_THREADS", + Math.max(2, Runtime.getRuntime().availableProcessors()), + Integer::parseUnsignedInt); + + /** Whether to use the shared worker pool when planning table scans. */ + public static final ConfigEntry<Boolean> SCAN_THREAD_POOL_ENABLED = + new ConfigEntry<>( + "iceberg.scan.plan-in-worker-pool", + "ICEBERG_SCAN_PLAN_IN_WORKER_POOL", + true, + Boolean::parseBoolean); + + /** + * Maximum number of distinct {@link org.apache.iceberg.io.FileIO} that is allowed to have + * associated {@link org.apache.iceberg.io.ContentCache} in memory at a time. + */ + public static final ConfigEntry<Integer> IO_MANIFEST_CACHE_MAX_FILEIO = + new ConfigEntry<>( + "iceberg.io.manifest.cache.fileio-max", + "ICEBERG_IO_MANIFEST_CACHE_FILEIO_MAX", + 8, + Integer::parseUnsignedInt); + + public static class ConfigEntry<T> { + private final String propertyKey; + private final String envKey; + private final T defaultValue; + private final Function<String, T> parseFunc; + + private ConfigEntry( + String propertyKey, String envKey, T defaultValue, Function<String, T> parseFunc) { + this.propertyKey = propertyKey; + this.envKey = envKey; + this.defaultValue = defaultValue; + this.parseFunc = parseFunc; + } + + public final String propertyKey() { + return propertyKey; + } + + public final String envKey() { + return envKey; + } + + public final T defaultValue() { + return defaultValue; + } + + public final T value() { + String value = System.getProperty(propertyKey); Review Comment: Updated with a cache value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
