amogh-jahagirdar opened a new pull request, #7561:
URL: https://github.com/apache/iceberg/pull/7561
Fixes #7173
Although this is really only an incremental improvement, because currently
the retry behavior in `ClientPoolImpl` is hardcoded to retry only once after
the initial request and without any backoff. Also currently, only a single
exception can be passed in for retries which is a bit limiting.
I think there's a good amount of room for refactoring ClientPoolImpl to
enable custom amount of retries and multiple exceptions similar to our `Tasks`
implementation.
Right now, the way retry can be tuned is by overriding
`isConnectionException` (same as what is done in HiveClientPoolImpl). I think
we can take refactoring separately since it'll be a bit more intrusive and in
the interim incrementally improve the behavior.
Furthermore, the exception that is currently being retried
`SqlNonTransientConnectionException` should not be retried. The client should
be retrying `SqlTransientConnectionException`, so this behavior has been fixed.
cc: @jackye1995 @singhpk234 @nastra @szehon-ho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
