jackye1995 commented on code in PR #7562: URL: https://github.com/apache/iceberg/pull/7562#discussion_r1189031910
########## aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java: ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.aws; + +import java.util.Map; +import org.apache.iceberg.common.DynClasses; +import org.apache.iceberg.common.DynMethods; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.base.Strings; +import org.apache.iceberg.util.PropertyUtil; +import software.amazon.awssdk.auth.credentials.AwsBasicCredentials; +import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider; +import software.amazon.awssdk.auth.credentials.AwsSessionCredentials; +import software.amazon.awssdk.auth.credentials.DefaultCredentialsProvider; +import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider; + +public class AwsClientProperties { + /** + * Configure the AWS credentials provider used to create AWS clients. A fully qualified concrete + * class with package that implements the {@link AwsCredentialsProvider} interface is required. + * + * <p>Additionally, the implementation class must also have a create() or create(Map) method + * implemented, which returns an instance of the class that provides aws credentials provider. + * + * <p>Example: + * client.credentials-provider=software.amazon.awssdk.auth.credentials.SystemPropertyCredentialsProvider + * + * <p>When set, the default client factory {@link + * org.apache.iceberg.aws.AwsClientFactories#defaultFactory()} and other AWS client factory + * classes will use this provider to get AWS credentials provided instead of reading the default + * credential chain to get AWS access credentials. + */ + public static final String CLIENT_CREDENTIALS_PROVIDER = "client.credentials-provider"; Review Comment: I think `client.region` also should be moved here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
