hililiwei commented on code in PR #7171:
URL: https://github.com/apache/iceberg/pull/7171#discussion_r1189469467
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##########
@@ -134,6 +135,19 @@ public static DataFile writeFile(
String filename,
List<RowData> rows)
throws IOException {
+ return writeFile(table, schema, spec, conf, location, filename, rows,
null);
+ }
+
+ public static DataFile writeFile(
Review Comment:
Yes, it's not necessary. Just wondering if we could explain it briefly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]