RussellSpitzer commented on code in PR #7361:
URL: https://github.com/apache/iceberg/pull/7361#discussion_r1191710981
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -337,14 +337,21 @@ private Result doExecuteWithPartialProgress(
commitManager.service(groupsPerCommit);
commitService.start();
+ List<FileGroupFailureResult> rewriteFailures =
Lists.newCopyOnWriteArrayList();
Review Comment:
In general this would probably be an expensive data-structure for this
operation since we never traverse. I don't think this is ever going to be that
huge, but let's use something a bit more efficient.
I think something like
ConcurrentLinkedQueue would be fine here, and then we could just create a
list out of it when we are done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
