stevenzwu commented on code in PR #7493:
URL: https://github.com/apache/iceberg/pull/7493#discussion_r1192547402
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/data/RowDataProjection.java:
##########
@@ -254,4 +258,78 @@ public MapData getMap(int pos) {
public RowData getRow(int pos, int numFields) {
return (RowData) getValue(pos);
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+
+ if (!(o instanceof RowDataProjection)) {
+ return false;
+ }
+
+ RowDataProjection that = (RowDataProjection) o;
+ return deepEquals(that);
+ }
+
+ @Override
+ public int hashCode() {
+ int result = Objects.hashCode(getRowKind());
+ for (int pos = 0; pos < getArity(); pos++) {
+ if (!isNullAt(pos)) {
+ // Arrays.deepHashCode handles array object properly
+ result = 31 * result + Arrays.deepHashCode(new Object[]
{getValue(pos)});
Review Comment:
@yegangy0718 Java List and Map objects implements `hashCode` properly. here
we are just leveraging `java.util.Arrays` to handle the hashCode for array type
field.
@hililiwei what do you mean by preferring the first one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
